Update the CodeQL workflow #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
May 10, 2024
dav3r
approved these changes
May 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
mcdonnnj
force-pushed
the
improvement/update_codeql_workflow
branch
from
6076975 to
93ade6e
Compare
mcdonnnj
added
the
kraken 🐙
This mirrors the diagnostics job in the `build` workflow.
Since this Action should be used in every job we need to use it here.
Once enabled downstream this will ensure that downstream projects will receive updates to this dependency from the upstream skeleton (which will get updated by dependabot) instead of in the downstream repository.
mcdonnnj
force-pushed
the
improvement/update_codeql_workflow
branch
from
b27a28a to
4dabc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the CodeQL workflow to reflect updates done in other skeleton projects.
Note
This pull request is built on top of #19 so you can see just this pull request's changes in this comparison.
💭 Motivation and context
In addition to spreading the
diagnosticsjob love and GHA runner hardening it was important to make sure the base configuration aligned with what's used in other projects (like cisagov/skeleton-python-library).🧪 Testing
Automated tests pass.
✅ Pre-approval checklist